more functional design principles

test/unit/logger.spec.js

@@ -2,41 +2,43 @@ import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest'
 import { info, error, warn, debug, setContext, clearContext, runWithContext } from '../../server/utils/logger.js'
 
 describe('logger', () => {
-  let originalLog
-  let originalError
-  let originalWarn
-  let originalDebug
-  let logCalls
-  let errorCalls
-  let warnCalls
-  let debugCalls
+  const testState = {
+    originalLog: null,
+    originalError: null,
+    originalWarn: null,
+    originalDebug: null,
+    logCalls: [],
+    errorCalls: [],
+    warnCalls: [],
+    debugCalls: [],
+  }
 
   beforeEach(() => {
-    logCalls = []
-    errorCalls = []
-    warnCalls = []
-    debugCalls = []
-    originalLog = console.log
-    originalError = console.error
-    originalWarn = console.warn
-    originalDebug = console.debug
-    console.log = vi.fn((...args) => logCalls.push(args))
-    console.error = vi.fn((...args) => errorCalls.push(args))
-    console.warn = vi.fn((...args) => warnCalls.push(args))
-    console.debug = vi.fn((...args) => debugCalls.push(args))
+    testState.logCalls = []
+    testState.errorCalls = []
+    testState.warnCalls = []
+    testState.debugCalls = []
+    testState.originalLog = console.log
+    testState.originalError = console.error
+    testState.originalWarn = console.warn
+    testState.originalDebug = console.debug
+    console.log = vi.fn((...args) => testState.logCalls.push(args))
+    console.error = vi.fn((...args) => testState.errorCalls.push(args))
+    console.warn = vi.fn((...args) => testState.warnCalls.push(args))
+    console.debug = vi.fn((...args) => testState.debugCalls.push(args))
   })
 
   afterEach(() => {
-    console.log = originalLog
-    console.error = originalError
-    console.warn = originalWarn
-    console.debug = originalDebug
+    console.log = testState.originalLog
+    console.error = testState.originalError
+    console.warn = testState.originalWarn
+    console.debug = testState.originalDebug
   })
 
   it('logs info message', () => {
     info('Test message')
-    expect(logCalls.length).toBe(1)
-    const logMsg = logCalls[0][0]
+    expect(testState.logCalls.length).toBe(1)
+    const logMsg = testState.logCalls[0][0]
     expect(logMsg).toContain('[INFO]')
     expect(logMsg).toContain('Test message')
   })
@@ -44,7 +46,7 @@ describe('logger', () => {
   it('includes request context when set', async () => {
     await runWithContext('req-123', 'user-456', async () => {
       info('Test message')
-      const logMsg = logCalls[0][0]
+      const logMsg = testState.logCalls[0][0]
       expect(logMsg).toContain('req-123')
       expect(logMsg).toContain('user-456')
     })
@@ -52,7 +54,7 @@ describe('logger', () => {
 
   it('includes additional context', () => {
     info('Test message', { key: 'value', count: 42 })
-    const logMsg = logCalls[0][0]
+    const logMsg = testState.logCalls[0][0]
     expect(logMsg).toContain('key')
     expect(logMsg).toContain('value')
     expect(logMsg).toContain('42')
@@ -61,8 +63,8 @@ describe('logger', () => {
   it('logs error with stack trace', () => {
     const err = new Error('Test error')
     error('Failed', { error: err })
-    expect(errorCalls.length).toBe(1)
-    const errorMsg = errorCalls[0][0]
+    expect(testState.errorCalls.length).toBe(1)
+    const errorMsg = testState.errorCalls[0][0]
     expect(errorMsg).toContain('[ERROR]')
     expect(errorMsg).toContain('Failed')
     expect(errorMsg).toContain('stack')
@@ -70,8 +72,8 @@ describe('logger', () => {
 
   it('logs warning', () => {
     warn('Warning message')
-    expect(warnCalls.length).toBe(1)
-    const warnMsg = warnCalls[0][0]
+    expect(testState.warnCalls.length).toBe(1)
+    const warnMsg = testState.warnCalls[0][0]
     expect(warnMsg).toContain('[WARN]')
   })
 
@@ -79,7 +81,7 @@ describe('logger', () => {
     const originalEnv = process.env.NODE_ENV
     process.env.NODE_ENV = 'development'
     debug('Debug message')
-    expect(debugCalls.length).toBe(1)
+    expect(testState.debugCalls.length).toBe(1)
     process.env.NODE_ENV = originalEnv
   })
 
@@ -87,19 +89,19 @@ describe('logger', () => {
     const originalEnv = process.env.NODE_ENV
     process.env.NODE_ENV = 'production'
     debug('Debug message')
-    expect(debugCalls.length).toBe(0)
+    expect(testState.debugCalls.length).toBe(0)
     process.env.NODE_ENV = originalEnv
   })
 
   it('clears context', async () => {
     await runWithContext('req-123', 'user-456', async () => {
       info('Test with context')
-      const logMsg = logCalls[0][0]
+      const logMsg = testState.logCalls[0][0]
       expect(logMsg).toContain('req-123')
     })
     // Context should be cleared after runWithContext completes
     info('Test without context')
-    const logMsg = logCalls[logCalls.length - 1][0]
+    const logMsg = testState.logCalls[testState.logCalls.length - 1][0]
     expect(logMsg).not.toContain('req-123')
   })
 
@@ -107,12 +109,12 @@ describe('logger', () => {
     await runWithContext(null, null, async () => {
       setContext('req-123', 'user-456')
       info('Test message')
-      const logMsg = logCalls[0][0]
+      const logMsg = testState.logCalls[0][0]
       expect(logMsg).toContain('req-123')
       expect(logMsg).toContain('user-456')
       clearContext()
       info('Test after clear')
-      const logMsg2 = logCalls[1][0]
+      const logMsg2 = testState.logCalls[1][0]
       expect(logMsg2).not.toContain('req-123')
     })
   })