refactor testing

test/unit/session.spec.js

@@ -1,39 +1,17 @@
-import { describe, it, expect, beforeEach, afterEach } from 'vitest'
-import { getSessionMaxAgeDays } from '../../server/utils/session.js'
+import { describe, it, expect } from 'vitest'
+import { getSessionMaxAgeDays } from '../../server/utils/constants.js'
+import { withTemporaryEnv } from '../helpers/env.js'
 
 describe('session', () => {
-  const origEnv = process.env
-
-  beforeEach(() => {
-    process.env = { ...origEnv }
-  })
-
-  afterEach(() => {
-    process.env = origEnv
-  })
-
-  it('returns default 7 days when SESSION_MAX_AGE_DAYS not set', () => {
-    delete process.env.SESSION_MAX_AGE_DAYS
-    expect(getSessionMaxAgeDays()).toBe(7)
-  })
-
-  it('returns default when SESSION_MAX_AGE_DAYS is NaN', () => {
-    process.env.SESSION_MAX_AGE_DAYS = 'invalid'
-    expect(getSessionMaxAgeDays()).toBe(7)
-  })
-
-  it('clamps to MIN_DAYS (1) when value below', () => {
-    process.env.SESSION_MAX_AGE_DAYS = '0'
-    expect(getSessionMaxAgeDays()).toBe(1)
-  })
-
-  it('clamps to MAX_DAYS (365) when value above', () => {
-    process.env.SESSION_MAX_AGE_DAYS = '400'
-    expect(getSessionMaxAgeDays()).toBe(365)
-  })
-
-  it('returns parsed value when within range', () => {
-    process.env.SESSION_MAX_AGE_DAYS = '14'
-    expect(getSessionMaxAgeDays()).toBe(14)
+  it.each([
+    [{ SESSION_MAX_AGE_DAYS: undefined }, 7],
+    [{ SESSION_MAX_AGE_DAYS: 'invalid' }, 7],
+    [{ SESSION_MAX_AGE_DAYS: '0' }, 1],
+    [{ SESSION_MAX_AGE_DAYS: '400' }, 365],
+    [{ SESSION_MAX_AGE_DAYS: '14' }, 14],
+  ])('returns correct days for SESSION_MAX_AGE_DAYS=%s', (env, expected) => {
+    withTemporaryEnv(env, () => {
+      expect(getSessionMaxAgeDays()).toBe(expected)
+    })
   })
 })