refactor testing

test/unit/authHelpers.spec.js

@@ -1,9 +1,7 @@
 import { describe, it, expect } from 'vitest'
 import { requireAuth } from '../../server/utils/authHelpers.js'
 
-function mockEvent(user = null) {
-  return { context: { user } }
-}
+const mockEvent = (user = null) => ({ context: { user } })
 
 describe('authHelpers', () => {
   it('requireAuth throws 401 when no user', () => {
@@ -19,43 +17,29 @@ describe('authHelpers', () => {
 
   it('requireAuth returns user when set', () => {
     const user = { id: '1', identifier: 'a@b.com', role: 'member' }
+    expect(requireAuth(mockEvent(user))).toEqual(user)
+  })
+
+  it.each([
+    ['member', 'adminOrLeader', 403],
+    ['admin', 'adminOrLeader', null],
+    ['leader', 'adminOrLeader', null],
+    ['leader', 'admin', 403],
+    ['admin', 'admin', null],
+  ])('requireAuth with %s role and %s requirement', (userRole, requirement, expectedStatus) => {
+    const user = { id: '1', identifier: 'a', role: userRole }
     const event = mockEvent(user)
-    expect(requireAuth(event)).toEqual(user)
-  })
-
-  it('requireAuth with adminOrLeader throws 403 for member', () => {
-    const event = mockEvent({ id: '1', identifier: 'a', role: 'member' })
-    expect(() => requireAuth(event, { role: 'adminOrLeader' })).toThrow()
-    try {
-      requireAuth(event, { role: 'adminOrLeader' })
+    if (expectedStatus === null) {
+      expect(requireAuth(event, { role: requirement })).toEqual(user)
     }
-    catch (e) {
-      expect(e.statusCode).toBe(403)
+    else {
+      expect(() => requireAuth(event, { role: requirement })).toThrow()
+      try {
+        requireAuth(event, { role: requirement })
+      }
+      catch (e) {
+        expect(e.statusCode).toBe(expectedStatus)
+      }
     }
   })
-
-  it('requireAuth with adminOrLeader returns user for admin', () => {
-    const user = { id: '1', identifier: 'a', role: 'admin' }
-    expect(requireAuth(mockEvent(user), { role: 'adminOrLeader' })).toEqual(user)
-  })
-
-  it('requireAuth with adminOrLeader returns user for leader', () => {
-    const user = { id: '1', identifier: 'a', role: 'leader' }
-    expect(requireAuth(mockEvent(user), { role: 'adminOrLeader' })).toEqual(user)
-  })
-
-  it('requireAuth with admin throws 403 for leader', () => {
-    const event = mockEvent({ id: '1', identifier: 'a', role: 'leader' })
-    try {
-      requireAuth(event, { role: 'admin' })
-    }
-    catch (e) {
-      expect(e.statusCode).toBe(403)
-    }
-  })
-
-  it('requireAuth with admin returns user for admin', () => {
-    const user = { id: '1', identifier: 'a', role: 'admin' }
-    expect(requireAuth(mockEvent(user), { role: 'admin' })).toEqual(user)
-  })
 })