From 06f9a5b96e63ad05d82b40a3d95c77d55c5c7480 Mon Sep 17 00:00:00 2001
From: Madison Grubb <madison@elastiflow.com>
Date: Thu, 12 Feb 2026 13:39:45 -0500
Subject: [PATCH] fix linting and testing stages

---
 .woodpecker/ci.yml                              | 1 +
 server/api/live/webrtc/create-transport.post.js | 2 +-
 server/utils/liveSessions.js                    | 4 ++--
 server/utils/mediasoup.js                       | 6 +++---
 server/utils/webrtcSignaling.js                 | 2 +-
 test/unit/mediasoup.spec.js                     | 4 ++--
 6 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/.woodpecker/ci.yml b/.woodpecker/ci.yml
index 50ee7b0..c589a86 100644
--- a/.woodpecker/ci.yml
+++ b/.woodpecker/ci.yml
@@ -12,6 +12,7 @@ steps:
     image: node:24-slim
     depends_on: []
     commands:
+      - npm ci
       - npm run test
     when:
       - event: pull_request
diff --git a/server/api/live/webrtc/create-transport.post.js b/server/api/live/webrtc/create-transport.post.js
index 6cee17c..25de2b4 100644
--- a/server/api/live/webrtc/create-transport.post.js
+++ b/server/api/live/webrtc/create-transport.post.js
@@ -26,7 +26,7 @@ export default defineEventHandler(async (event) => {
   const url = getRequestURL(event)
   const requestHost = url.hostname
   const router = await getRouter(sessionId)
-  const { transport, params } = await createTransport(router, Boolean(isProducer), requestHost)
+  const { transport, params } = await createTransport(router, requestHost)
 
   if (isProducer) {
     updateLiveSession(sessionId, {
diff --git a/server/utils/liveSessions.js b/server/utils/liveSessions.js
index 0e8dcca..9e7f40b 100644
--- a/server/utils/liveSessions.js
+++ b/server/utils/liveSessions.js
@@ -20,7 +20,7 @@ export const createSession = (userId, label = '') => {
   return session
 }
 
-export const getLiveSession = (id) => sessions.get(id)
+export const getLiveSession = id => sessions.get(id)
 
 export const getActiveSessionByUserId = (userId) => {
   const now = Date.now()
@@ -41,7 +41,7 @@ export const updateLiveSession = (id, updates) => {
   session.updatedAt = now
 }
 
-export const deleteLiveSession = (id) => sessions.delete(id)
+export const deleteLiveSession = id => sessions.delete(id)
 
 export const clearSessions = () => sessions.clear()
 
diff --git a/server/utils/mediasoup.js b/server/utils/mediasoup.js
index 79166f6..18b68fb 100644
--- a/server/utils/mediasoup.js
+++ b/server/utils/mediasoup.js
@@ -63,7 +63,7 @@ const resolveAnnouncedIp = (requestHost) => {
   return getAnnouncedIpFromInterfaces()
 }
 
-export const createTransport = async (router, _isProducer = false, requestHost = undefined) => {
+export const createTransport = async (router, requestHost = undefined) => {
   const announcedIp = resolveAnnouncedIp(requestHost)
   const listenIps = announcedIp
     ? [{ ip: '0.0.0.0', announcedIp }, { ip: '127.0.0.1' }]
@@ -94,7 +94,7 @@ export const createTransport = async (router, _isProducer = false, requestHost =
   }
 }
 
-export const getTransport = (transportId) => transports.get(transportId)
+export const getTransport = transportId => transports.get(transportId)
 
 export const createProducer = async (transport, track) => {
   const producer = await transport.produce({ track })
@@ -103,7 +103,7 @@ export const createProducer = async (transport, track) => {
   return producer
 }
 
-export const getProducer = (producerId) => producers.get(producerId)
+export const getProducer = producerId => producers.get(producerId)
 
 export const getTransports = () => transports
 
diff --git a/server/utils/webrtcSignaling.js b/server/utils/webrtcSignaling.js
index d07c1bb..526dd06 100644
--- a/server/utils/webrtcSignaling.js
+++ b/server/utils/webrtcSignaling.js
@@ -32,7 +32,7 @@ export async function handleWebSocketMessage(userId, sessionId, type, data) {
       }
       case 'create-transport': {
         const router = await getRouter(sessionId)
-        const { transport, params } = await createTransport(router, true)
+        const { transport, params } = await createTransport(router)
         updateLiveSession(sessionId, { transportId: transport.id, routerId: router.id })
         return { type: 'transport-created', data: params }
       }
diff --git a/test/unit/mediasoup.spec.js b/test/unit/mediasoup.spec.js
index 8e3dd1e..6906749 100644
--- a/test/unit/mediasoup.spec.js
+++ b/test/unit/mediasoup.spec.js
@@ -25,7 +25,7 @@ describe('Mediasoup', () => {
 
   it('should create a transport', async () => {
     const router = await getRouter(sessionId)
-    const { transport, params } = await createTransport(router, true)
+    const { transport, params } = await createTransport(router)
     expect(transport).toBeDefined()
     expect(params.id).toBe(transport.id)
     expect(params.iceParameters).toBeDefined()
@@ -35,7 +35,7 @@ describe('Mediasoup', () => {
 
   it('should create a transport with requestHost IPv4 and return valid params', async () => {
     const router = await getRouter(sessionId)
-    const { transport, params } = await createTransport(router, true, '192.168.2.100')
+    const { transport, params } = await createTransport(router, '192.168.2.100')
     expect(transport).toBeDefined()
     expect(params.id).toBe(transport.id)
     expect(params.iceParameters).toBeDefined()